From a649b6788034ffa19761cd5783c45dfb1c0c32d0 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Tue, 17 Oct 2023 22:54:08 +0200 Subject: [PATCH] machineid: document flaky test --- src/modules/machineid/Tests.cpp | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/modules/machineid/Tests.cpp b/src/modules/machineid/Tests.cpp index 769751c75..299240f0e 100644 --- a/src/modules/machineid/Tests.cpp +++ b/src/modules/machineid/Tests.cpp @@ -19,6 +19,8 @@ #include #include +#include + // Internals of Workers.cpp extern int getUrandomPoolSize(); @@ -148,8 +150,21 @@ MachineIdTests::testPoolSize() // It hardly makes sense, but also the /proc entry is missing QCOMPARE( getUrandomPoolSize(), 512 ); #else - // Based on a sample size of 1, Netrunner - QCOMPARE( getUrandomPoolSize(), 4096 ); + // Based on a sample size of 1, Netrunner had 4096. + // Physical HW KDE neon had 256, which gets reported as 512, + // but regular CI builds pass, so leave that special case + // #if-fed out. +#if 0 + KOSRelease r; + if ( r.id() == QStringLiteral( "neon" ) ) + { + QCOMPARE( getUrandomPoolSize(), 512 ); + } + else +#endif + { + QCOMPARE( getUrandomPoolSize(), 4096 ); + } #endif }