[libcalamares] Reformat new code in partition service

This commit is contained in:
Adriaan de Groot 2019-06-13 14:47:44 +02:00
parent 4b3bb54320
commit 93742a8efe
2 changed files with 25 additions and 14 deletions

View File

@ -58,8 +58,10 @@ findPartitionByCurrentMountPoint( const QList< Device* >& devices, const QString
{ {
for ( auto device : devices ) for ( auto device : devices )
for ( auto it = PartitionIterator::begin( device ); it != PartitionIterator::end( device ); ++it ) for ( auto it = PartitionIterator::begin( device ); it != PartitionIterator::end( device ); ++it )
if ( (*it)->mountPoint() == mountPoint ) if ( ( *it )->mountPoint() == mountPoint )
{
return *it; return *it;
}
return nullptr; return nullptr;
} }
@ -68,28 +70,33 @@ Partition*
findPartitionByPath( const QList< Device* >& devices, const QString& path ) findPartitionByPath( const QList< Device* >& devices, const QString& path )
{ {
if ( path.simplified().isEmpty() ) if ( path.simplified().isEmpty() )
{
return nullptr; return nullptr;
}
for ( auto device : devices ) for ( auto device : devices )
for ( auto it = PartitionIterator::begin( device ); it != PartitionIterator::end( device ); ++it ) for ( auto it = PartitionIterator::begin( device ); it != PartitionIterator::end( device ); ++it )
if ( ( *it )->partitionPath() == path.simplified() ) if ( ( *it )->partitionPath() == path.simplified() )
{
return *it; return *it;
}
return nullptr; return nullptr;
} }
QList< Partition* > QList< Partition* >
findPartitions( const QList< Device* >& devices, findPartitions( const QList< Device* >& devices, std::function< bool( Partition* ) > criterionFunction )
std::function< bool ( Partition* ) > criterionFunction )
{ {
QList< Partition* > results; QList< Partition* > results;
for ( auto device : devices ) for ( auto device : devices )
for ( auto it = PartitionIterator::begin( device ); it != PartitionIterator::end( device ); ++it ) for ( auto it = PartitionIterator::begin( device ); it != PartitionIterator::end( device ); ++it )
if ( criterionFunction( *it ) ) if ( criterionFunction( *it ) )
{
results.append( *it ); results.append( *it );
}
return results; return results;
} }
} } // namespace Partition
} // namespace } // namespace CalamaresUtils

View File

@ -33,38 +33,42 @@ namespace CalamaresUtils
{ {
namespace Partition namespace Partition
{ {
using ::Device;
using ::Partition;
/** @brief Is this a free-space area? */ /** @brief Is this a free-space area? */
bool isPartitionFreeSpace( ::Partition* ); bool isPartitionFreeSpace( Partition* );
/** @brief Is this partition newly-to-be-created? /** @brief Is this partition newly-to-be-created?
* *
* Returns true if the partition is planned to be created by the installer as * Returns true if the partition is planned to be created by the installer as
* opposed to already existing on the disk. * opposed to already existing on the disk.
*/ */
bool isPartitionNew( ::Partition* ); bool isPartitionNew( Partition* );
/** /**
* Iterates on all devices and return the first partition which is (already) * Iterates on all devices and return the first partition which is (already)
* mounted on @p mountPoint. * mounted on @p mountPoint.
*/ */
::Partition* findPartitionByCurrentMountPoint( const QList< ::Device* >& devices, const QString& mountPoint ); Partition* findPartitionByCurrentMountPoint( const QList< Device* >& devices, const QString& mountPoint );
// TODO: add this distinction // TODO: add this distinction
// ::Partition* findPartitionByIntendedMountPoint( const QList< ::Device* >& devices, const QString& mountPoint ); // Partition* findPartitionByIntendedMountPoint( const QList< Device* >& devices, const QString& mountPoint );
/** /**
* Iterates on all devices and partitions and returns a pointer to the Partition object * Iterates on all devices and partitions and returns a pointer to the Partition object
* for the given path, or nullptr if a Partition for the given path cannot be found. * for the given path, or nullptr if a Partition for the given path cannot be found.
*/ */
::Partition* findPartitionByPath( const QList< ::Device* >& devices, const QString& path ); Partition* findPartitionByPath( const QList< Device* >& devices, const QString& path );
/** /**
* Iterates on all devices and partitions and returns a list of pointers to the Partition * Iterates on all devices and partitions and returns a list of pointers to the Partition
* objects that satisfy the conditions defined in the criterion function. * objects that satisfy the conditions defined in the criterion function.
*/ */
QList< ::Partition* > findPartitions( const QList< ::Device* >& devices, QList< Partition* > findPartitions( const QList< Device* >& devices,
std::function< bool ( ::Partition* ) > criterionFunction ); std::function< bool( Partition* ) > criterionFunction );
} } // namespace Partition
} } // namespace CalamaresUtils
#endif // PARTITION_PARTITIONQUERY_H #endif // PARTITION_PARTITIONQUERY_H