From 8d3530154f007793a7e50223512a155ef68395e5 Mon Sep 17 00:00:00 2001
From: Adriaan de Groot <groot@kde.org>
Date: Tue, 20 Aug 2019 09:57:04 -0400
Subject: [PATCH] [libcalamares] Expand network service test

 - Do an actual ping (also to check for memory leaks)
---
 src/libcalamares/network/Tests.cpp | 25 +++++++++++++++----------
 src/libcalamares/network/Tests.h   |  1 +
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/src/libcalamares/network/Tests.cpp b/src/libcalamares/network/Tests.cpp
index a13a74c86..559a955fe 100644
--- a/src/libcalamares/network/Tests.cpp
+++ b/src/libcalamares/network/Tests.cpp
@@ -24,20 +24,25 @@
 
 QTEST_GUILESS_MAIN( NetworkTests )
 
-NetworkTests::NetworkTests()
+NetworkTests::NetworkTests() {}
+
+NetworkTests::~NetworkTests() {}
+
+void
+NetworkTests::initTestCase()
 {
 }
 
-NetworkTests::~NetworkTests()
-{
-}
-
-void NetworkTests::initTestCase()
-{
-}
-
-void NetworkTests::testInstance()
+void
+NetworkTests::testInstance()
 {
     auto& nam = CalamaresUtils::Network::Manager::instance();
     QVERIFY( !nam.hasInternet() );
 }
+
+void
+NetworkTests::testPing()
+{
+    auto& nam = CalamaresUtils::Network::Manager::instance();
+    QVERIFY( nam.synchronousPing( QUrl( "https://www.kde.org" ) ) );
+}
diff --git a/src/libcalamares/network/Tests.h b/src/libcalamares/network/Tests.h
index 56f87cc67..b63f7eff0 100644
--- a/src/libcalamares/network/Tests.h
+++ b/src/libcalamares/network/Tests.h
@@ -32,6 +32,7 @@ private Q_SLOTS:
     void initTestCase();
 
     void testInstance();
+    void testPing();
 };
 
 #endif