napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[libcalamares] Reduce object churn

Browse Source 
- we don't need to allocate a new translator each time the language changes
This commit is contained in:
Adriaan de Groot 2020-11-05 00:09:23 +01:00
parent 59255c7a57
commit 83b2b95381
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/libcalamares/utils/Retranslator.cpp
View File

@ -168,17 +168,17 @@ TZLoader::tryLoad( QTranslator* translator )
static void static void
loadSingletonTranslator( TranslationLoader&& loader, QTranslator*& translator_p ) loadSingletonTranslator( TranslationLoader&& loader, QTranslator*& translator_p )
{ {
if ( !translator_p )
{
QTranslator* translator = new QTranslator(); QTranslator* translator = new QTranslator();
loader.tryLoad( translator ); loader.tryLoad( translator );
if ( translator_p )
{
QCoreApplication::removeTranslator( translator_p );
delete translator_p;
}
QCoreApplication::installTranslator( translator ); QCoreApplication::installTranslator( translator );
translator_p = translator; translator_p = translator;
}
else
{
loader.tryLoad( translator_p );
}
} }
namespace CalamaresUtils namespace CalamaresUtils