From 81499b22a1815ba1d38daa8d4064ae37b6940e4f Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Fri, 10 May 2019 10:57:50 -0400 Subject: [PATCH] [libcalamares] Fix build of tests - Link Qt::Xml publicly because the tests will need it as well. --- src/libcalamares/CMakeLists.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libcalamares/CMakeLists.txt b/src/libcalamares/CMakeLists.txt index 585ab7b6b..ad1c7f336 100644 --- a/src/libcalamares/CMakeLists.txt +++ b/src/libcalamares/CMakeLists.txt @@ -14,6 +14,7 @@ configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/../calamares/CalamaresVersion.h.in ${CMAKE_CURRENT_BINARY_DIR}/CalamaresVersion.h ) set( OPTIONAL_PRIVATE_LIBRARIES "" ) +set( OPTIONAL_PUBLIC_LIBRARIES "" ) set( libSources CppJob.cpp @@ -92,7 +93,7 @@ endif() find_package(Qt5 COMPONENTS Xml) if( Qt5Xml_FOUND ) list( APPEND libSources geoip/GeoIPXML.cpp ) - list( APPEND OPTIONAL_PRIVATE_LIBRARIES Qt5::Network Qt5::Xml ) + list( APPEND OPTIONAL_PUBLIC_LIBRARIES Qt5::Network Qt5::Xml ) endif() ### LIBRARY @@ -112,6 +113,7 @@ target_link_libraries( calamares LINK_PUBLIC ${YAMLCPP_LIBRARY} Qt5::Core + ${OPTIONAL_PUBLIC_LIBRARIES} ) install( TARGETS calamares