[libcalamares] Put GeoIP in namespace

- Use consistent include-guard style
 - Put things in namespace CalamaresUtils

src/libcalamares/geoip/GeoIP.cpp

@@ -20,6 +20,9 @@
 
 #include "utils/Logger.h"
 
+namespace CalamaresUtils
+{
+
 GeoIP::GeoIP(const QString& e)
     : m_element( e )
 {
@@ -47,3 +50,5 @@ GeoIP::splitTZString( const QString& tz )
 
     return qMakePair( QString(), QString() );
 }
+
+}  // namespace

src/libcalamares/geoip/GeoIP.h

@@ -1,6 +1,6 @@
 /* === This file is part of Calamares - <http://github.com/calamares> ===
  *
- *   Copyright 2018, Adriaan de Groot <groot@kde.org>
+ *   Copyright 2018-2019, Adriaan de Groot <groot@kde.org>
  *
  *   Calamares is free software: you can redistribute it and/or modify
  *   it under the terms of the GNU General Public License as published by
@@ -16,8 +16,8 @@
  *   along with Calamares. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#ifndef GEOIP_H
+#ifndef GEOIP_GEOIP_H
-#define GEOIP_H
+#define GEOIP_GEOIP_H
 
 #include <QPair>
 #include <QString>
@@ -25,6 +25,8 @@
 
 class QByteArray;
 
+namespace CalamaresUtils
+{
 /**
  * @brief Interface for GeoIP retrievers.
  *
@@ -67,4 +69,5 @@ protected:
     QString m_element;  // string for selecting from data
 } ;
 
+}  // namespace
 #endif

src/libcalamares/geoip/GeoIPJSON.cpp

@@ -25,6 +25,9 @@
 
 #include <QByteArray>
 
+namespace CalamaresUtils
+{
+
 GeoIPJSON::GeoIPJSON(const QString& attribute)
     : GeoIP( attribute.isEmpty() ? QStringLiteral( "time_zone" ) : attribute )
 {
@@ -72,3 +75,5 @@ GeoIPJSON::processReply( const QByteArray& data )
 
     return qMakePair( QString(), QString() );
 }
+
+}  // namespace

src/libcalamares/geoip/GeoIPJSON.h

@@ -1,6 +1,6 @@
 /* === This file is part of Calamares - <http://github.com/calamares> ===
  *
- *   Copyright 2018, Adriaan de Groot <groot@kde.org>
+ *   Copyright 2018-2019, Adriaan de Groot <groot@kde.org>
  *
  *   Calamares is free software: you can redistribute it and/or modify
  *   it under the terms of the GNU General Public License as published by
@@ -16,11 +16,13 @@
  *   along with Calamares. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#ifndef GEOIPJSON_H
+#ifndef GEOIP_GEOIPJSON_H
-#define GEOIPJSON_H
+#define GEOIP_GEOIPJSON_H
 
 #include "GeoIP.h"
 
+namespace CalamaresUtils
+{
 /** @brief GeoIP lookup for services that return JSON.
  *
  * This is the original implementation of GeoIP lookup,
@@ -41,4 +43,5 @@ public:
     virtual RegionZonePair processReply( const QByteArray& );
 } ;
 
+}  // namespace
 #endif

src/libcalamares/geoip/GeoIPTests.cpp

@@ -31,6 +31,10 @@
 
 QTEST_GUILESS_MAIN( GeoIPTests )
 
+using CalamaresUtils::GeoIP;
+using CalamaresUtils::GeoIPJSON;
+using CalamaresUtils::GeoIPXML;
+
 GeoIPTests::GeoIPTests()
 {
 }

src/libcalamares/geoip/GeoIPXML.cpp

@@ -23,6 +23,9 @@
 #include <QNetworkReply>
 #include <QtXml/QDomDocument>
 
+namespace CalamaresUtils
+{
+
 GeoIPXML::GeoIPXML( const QString& element )
     : GeoIP( element.isEmpty() ? QStringLiteral( "TimeZone" ) : element )
 {
@@ -58,3 +61,5 @@ GeoIPXML::processReply( const QByteArray& data )
 
     return qMakePair( QString(), QString() );
 }
+
+}  // namespace

src/libcalamares/geoip/GeoIPXML.h

@@ -1,6 +1,6 @@
 /* === This file is part of Calamares - <http://github.com/calamares> ===
  *
- *   Copyright 2018, Adriaan de Groot <groot@kde.org>
+ *   Copyright 2018-2019, Adriaan de Groot <groot@kde.org>
  *
  *   Calamares is free software: you can redistribute it and/or modify
  *   it under the terms of the GNU General Public License as published by
@@ -16,11 +16,13 @@
  *   along with Calamares. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#ifndef GEOIPXML_H
+#ifndef GEOIP_GEOIPXML_H
-#define GEOIPXML_H
+#define GEOIP_GEOIPXML_H
 
 #include "GeoIP.h"
 
+namespace CalamaresUtils
+{
 /** @brief GeoIP lookup with XML data
  *
  * The data is assumed to be in XML format with a
@@ -41,4 +43,5 @@ public:
     virtual RegionZonePair processReply( const QByteArray& );
 } ;
 
+}  // namespace
 #endif

src/libcalamares/geoip/test_geoip.cpp

@@ -28,6 +28,9 @@
 #endif
 
 using std::cerr;
+using CalamaresUtils::GeoIP;
+using CalamaresUtils::GeoIPJSON;
+using CalamaresUtils::GeoIPXML;
 
 int main(int argc, char** argv)
 {

src/modules/locale/LocaleViewStep.cpp

@@ -117,6 +117,12 @@ LocaleViewStep::setUpPage()
 void
 LocaleViewStep::fetchGeoIpTimezone()
 {
+    using CalamaresUtils::GeoIP;
+    using CalamaresUtils::GeoIPJSON;
+#if defined(QT_XML_LIB)
+    using CalamaresUtils::GeoIPXML;
+#endif
+
     QString actualUrl( m_geoipUrl );
     GeoIP *handler = nullptr;