It is a good idea to initialize pointer members in the ctor.

2015-10-25 14:36:09 +01:00 · 2015-10-25 14:36:09 +01:00 · 6de8158bec
commit 6de8158bec
parent eeceed91eb
1 changed files with 5 additions and 4 deletions
--- a/src/libcalamaresui/utils/PluginFactory_p.h
+++ b/src/libcalamaresui/utils/PluginFactory_p.h
@ -36,10 +36,11 @@ class PluginFactoryPrivate
 protected:
    typedef QPair<const QMetaObject *, PluginFactory::CreateInstanceFunction> Plugin;

-    PluginFactoryPrivate() : catalogInitialized(false) {}
-    ~PluginFactoryPrivate()
-    {
-    }
+    PluginFactoryPrivate()
+        : catalogInitialized( false )
+        , q_ptr( nullptr )
+    {}
+    ~PluginFactoryPrivate() {}

    QHash<QString, Plugin> createInstanceHash;
    QString catalogName;