From 54108d2bab337dd42b10eea93658a675beae907d Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Tue, 14 May 2019 04:49:53 -0400 Subject: [PATCH] [partition] Fix up logging of jobs - Logging `*it` was printing raw pointers, logging (plain) `it` needs the specialized logging `operator<<` to DTRT with temporaries. --- src/modules/partition/jobs/CreatePartitionTableJob.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/partition/jobs/CreatePartitionTableJob.cpp b/src/modules/partition/jobs/CreatePartitionTableJob.cpp index 937b8437d..3465a0e2d 100644 --- a/src/modules/partition/jobs/CreatePartitionTableJob.cpp +++ b/src/modules/partition/jobs/CreatePartitionTableJob.cpp @@ -68,7 +68,7 @@ CreatePartitionTableJob::prettyStatusMessage() const static inline QDebug& -operator <<( QDebug& s, PartitionIterator& it ) +operator <<( QDebug&& s, PartitionIterator& it ) { s << ( ( *it ) ? ( *it )->deviceNode() : QString( "" ) ); return s; @@ -89,7 +89,7 @@ CreatePartitionTableJob::exec() { for ( auto it = PartitionIterator::begin( table ); it != PartitionIterator::end( table ); ++it ) - cDebug() << *it; + cDebug() << it; QProcess lsblk; lsblk.setProgram( "lsblk" );