[partition] Complain if unmount fails

- If unmount fails, then warn and don't autoremove
2018-11-02 12:04:09 -04:00 · 2018-11-02 12:04:09 -04:00 · 516ae494bf
commit 516ae494bf
parent bd1b482242
1 changed files with 6 additions and 1 deletions
--- a/src/modules/partition/core/PartUtils.cpp
+++ b/src/modules/partition/core/PartUtils.cpp
@ -196,7 +196,12 @@ lookForFstabEntries( const QString& partitionPath )
            fstabFile.close();
        }

-        QProcess::execute( "umount", { "-R", mountsDir.path() } );
+        if ( QProcess::execute( "umount", { "-R", mountsDir.path() } ) )
+        {
+            cWarning() << "Could not unmount" << mountsDir.path();
+            // There is stuff left in there, really don't remove
+            mountsDir.setAutoRemove( false );
+        }
    }

    return fstabEntries;