napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[libcalamares] Polish model

Browse Source 
- make signals consistent in carrying a parameter
- explain why there's no Q_ENUM
This commit is contained in:
Adriaan de Groot 2020-04-02 22:04:34 +02:00
parent d2f5185d49
commit 4e7020d030
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libcalamares/modulesystem/RequirementsModel.cpp
View File

@ -34,7 +34,7 @@ RequirementsModel::setRequirementsList( const Calamares::RequirementsList& requi
m_satisfiedMandatory = std::none_of( m_requirements.begin(), m_requirements.end(), isMandatoryAndUnSatisfied ); m_satisfiedMandatory = std::none_of( m_requirements.begin(), m_requirements.end(), isMandatoryAndUnSatisfied );
emit satisfiedRequirementsChanged( m_satisfiedRequirements ); emit satisfiedRequirementsChanged( m_satisfiedRequirements );
emit satisfiedMandatoryChanged(); emit satisfiedMandatoryChanged( m_satisfiedMandatory );
emit endResetModel(); emit endResetModel();
} }

3
src/libcalamares/modulesystem/RequirementsModel.h
View File

@ -46,6 +46,7 @@ public:
NegatedText, NegatedText,
HasDetails HasDetails
}; };
// No Q_ENUM because these are exposed through roleNames()
bool satisfiedRequirements() const { return m_satisfiedRequirements; } bool satisfiedRequirements() const { return m_satisfiedRequirements; }
bool satisfiedMandatory() const { return m_satisfiedMandatory; } bool satisfiedMandatory() const { return m_satisfiedMandatory; }
@ -76,7 +77,7 @@ private:
signals: signals:
void satisfiedRequirementsChanged( bool value ); void satisfiedRequirementsChanged( bool value );
void satisfiedMandatoryChanged(); void satisfiedMandatoryChanged( bool value );
void warningMessageChanged(); void warningMessageChanged();
}; };