napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

locale: Optimize guessLCLocale by moving function calls out of loops.

Browse Source
This commit is contained in:
Kevin Kofler 2014-11-25 19:44:16 +01:00
parent bcbe5103b9
commit 440b38addf
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/modules/locale/LocalePage.cpp
View File

@ -287,10 +287,11 @@ LocalePage::guessLCLocale()
if ( m_localeGenLines.isEmpty() ) if ( m_localeGenLines.isEmpty() )
return "en_US.UTF-8 UTF-8"; return "en_US.UTF-8 UTF-8";
QString myLanguage = QLocale::languageToString( myLocale.language() );
QStringList linesForLanguage; QStringList linesForLanguage;
foreach ( QString line, m_localeGenLines ) foreach ( QString line, m_localeGenLines )
{ {
if ( line.startsWith( QLocale::languageToString( myLocale.language() ) ) ) if ( line.startsWith( myLanguage ) )
linesForLanguage.append( line ); linesForLanguage.append( line );
} }
@ -312,10 +313,10 @@ LocalePage::guessLCLocale()
} }
// FIXME: use reverse geocoding to guess the country // FIXME: use reverse geocoding to guess the country
QString prefix = myLocale.name();
QStringList linesForLanguageAndCountry; QStringList linesForLanguageAndCountry;
foreach ( QString line, linesForLanguage ) foreach ( QString line, linesForLanguage )
{ {
QString prefix = myLocale.name();
if ( line.startsWith( prefix ) ) if ( line.startsWith( prefix ) )
linesForLanguageAndCountry.append( line ); linesForLanguageAndCountry.append( line );
} }