From 353e713f8146b25b9553d0aece2b85de957ddea8 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Fri, 31 May 2019 10:41:50 +0200 Subject: [PATCH] [partition] Complain loudly on dangling Partition pointers - Don't crash if a bad pointer gets into colorutils. --- src/modules/partition/core/ColorUtils.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/modules/partition/core/ColorUtils.cpp b/src/modules/partition/core/ColorUtils.cpp index 40f65d2ba..ffe45d443 100644 --- a/src/modules/partition/core/ColorUtils.cpp +++ b/src/modules/partition/core/ColorUtils.cpp @@ -22,6 +22,8 @@ #include "core/KPMHelpers.h" #include "core/PartitionIterator.h" +#include "utils/Logger.h" + // KPMcore #include #include @@ -81,6 +83,12 @@ _findRootForPartition( PartitionNode* partition ) QColor colorForPartition( Partition* partition ) { + if ( !partition ) + { + cWarning() << "NULL partition"; + return FREE_SPACE_COLOR; + } + if ( KPMHelpers::isPartitionFreeSpace( partition ) ) return FREE_SPACE_COLOR; if ( partition->roles().has( PartitionRole::Extended ) )