[libcalamares] Revert PRIVATETEST

- looks funny
- is hard to get clang-format to respect this; it's intended as an
  access-modifier, but those are baked into the code rather than
  being configurable.
- is probably rare enough that #ifdef is acceptable

src/libcalamares/DllMacro.h

@@ -76,16 +76,4 @@
 #endif
 #endif
 
-/*
- * For private functions that should be public for testing purposes,
- * use PRIVATETEST, which is private except when building tests.
- */
-#ifndef PRIVATETEST
-#if defined( BUILD_AS_TEST )
-#define PRIVATETEST public
-#else
-#define PRIVATETEST private
-#endif
-#endif
-
 #endif

src/libcalamares/Settings.h

@@ -46,7 +46,10 @@ class DLLEXPORT InstanceDescription
 {
     using InstanceKey = Calamares::ModuleSystem::InstanceKey;
 
-    PRIVATETEST : InstanceDescription( InstanceKey&& key, int weight );
+#ifdef BUILD_AS_TEST
+public:
+#endif
+    InstanceDescription( InstanceKey&& key, int weight );
 
 public:
     /** @brief An invalid InstanceDescription