From 337903db09c4196ea17313386933d4e1f19e7492 Mon Sep 17 00:00:00 2001
From: Adriaan de Groot <groot@kde.org>
Date: Wed, 20 Sep 2017 08:24:28 -0400
Subject: [PATCH] Clang: reduce warnings about overriden destructors

---
 src/libcalamares/ProcessJob.h                      | 2 +-
 src/libcalamaresui/modulesystem/CppJobModule.h     | 2 +-
 src/libcalamaresui/modulesystem/ProcessJobModule.h | 2 +-
 src/libcalamaresui/modulesystem/ViewModule.h       | 2 +-
 src/modules/finished/FinishedViewStep.h            | 2 +-
 src/modules/license/LicenseViewStep.h              | 4 ++--
 src/modules/locale/LocaleViewStep.h                | 2 +-
 src/modules/partition/core/BootLoaderModel.h       | 2 +-
 src/modules/summary/SummaryViewStep.h              | 2 +-
 src/modules/welcome/WelcomeViewStep.h              | 2 +-
 10 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/libcalamares/ProcessJob.h b/src/libcalamares/ProcessJob.h
index 259f97308..43fdf254e 100644
--- a/src/libcalamares/ProcessJob.h
+++ b/src/libcalamares/ProcessJob.h
@@ -33,7 +33,7 @@ public:
                          bool runInChroot = false,
                          int secondsTimeout = 30,
                          QObject* parent = nullptr );
-    virtual ~ProcessJob();
+    virtual ~ProcessJob() override;
 
     QString prettyName() const override;
     QString prettyStatusMessage() const override;
diff --git a/src/libcalamaresui/modulesystem/CppJobModule.h b/src/libcalamaresui/modulesystem/CppJobModule.h
index 875f30785..46d27bf8b 100644
--- a/src/libcalamaresui/modulesystem/CppJobModule.h
+++ b/src/libcalamaresui/modulesystem/CppJobModule.h
@@ -44,7 +44,7 @@ protected:
 private:
     friend class Module; //so only the superclass can instantiate
     explicit CppJobModule();
-    virtual ~CppJobModule();
+    virtual ~CppJobModule() override;
 
     QPluginLoader* m_loader;
     job_ptr m_job;
diff --git a/src/libcalamaresui/modulesystem/ProcessJobModule.h b/src/libcalamaresui/modulesystem/ProcessJobModule.h
index 9d30ec235..af9a46bd5 100644
--- a/src/libcalamaresui/modulesystem/ProcessJobModule.h
+++ b/src/libcalamaresui/modulesystem/ProcessJobModule.h
@@ -42,7 +42,7 @@ protected:
 private:
     friend class Module;
     explicit ProcessJobModule();
-    virtual ~ProcessJobModule();
+    virtual ~ProcessJobModule() override;
 
     QString m_command;
     QString m_workingPath;
diff --git a/src/libcalamaresui/modulesystem/ViewModule.h b/src/libcalamaresui/modulesystem/ViewModule.h
index 32b0e8a1f..6b2e381a2 100644
--- a/src/libcalamaresui/modulesystem/ViewModule.h
+++ b/src/libcalamaresui/modulesystem/ViewModule.h
@@ -45,7 +45,7 @@ protected:
 private:
     friend class Module; //so only the superclass can instantiate
     explicit ViewModule();
-    virtual ~ViewModule();
+    virtual ~ViewModule() override;
 
     QPluginLoader* m_loader;
     ViewStep* m_viewStep = nullptr;
diff --git a/src/modules/finished/FinishedViewStep.h b/src/modules/finished/FinishedViewStep.h
index cb3656046..6a11dc8a3 100644
--- a/src/modules/finished/FinishedViewStep.h
+++ b/src/modules/finished/FinishedViewStep.h
@@ -34,7 +34,7 @@ class PLUGINDLLEXPORT FinishedViewStep : public Calamares::ViewStep
 
 public:
     explicit FinishedViewStep( QObject* parent = nullptr );
-    virtual ~FinishedViewStep();
+    virtual ~FinishedViewStep() override;
 
     QString prettyName() const override;
 
diff --git a/src/modules/license/LicenseViewStep.h b/src/modules/license/LicenseViewStep.h
index 6229853ba..07824a5e3 100644
--- a/src/modules/license/LicenseViewStep.h
+++ b/src/modules/license/LicenseViewStep.h
@@ -36,7 +36,7 @@ class PLUGINDLLEXPORT LicenseViewStep : public Calamares::ViewStep
 
 public:
     explicit LicenseViewStep( QObject* parent = nullptr );
-    virtual ~LicenseViewStep();
+    virtual ~LicenseViewStep() override;
 
     QString prettyName() const override;
 
@@ -52,7 +52,7 @@ public:
     bool isAtEnd() const override;
 
     QList< Calamares::job_ptr > jobs() const override;
-    
+
     void setConfigurationMap( const QVariantMap& configurationMap ) override;
 
 private:
diff --git a/src/modules/locale/LocaleViewStep.h b/src/modules/locale/LocaleViewStep.h
index 2785f3d4a..402fb7ce9 100644
--- a/src/modules/locale/LocaleViewStep.h
+++ b/src/modules/locale/LocaleViewStep.h
@@ -37,7 +37,7 @@ class PLUGINDLLEXPORT LocaleViewStep : public Calamares::ViewStep
 
 public:
     explicit LocaleViewStep( QObject* parent = nullptr );
-    virtual ~LocaleViewStep();
+    virtual ~LocaleViewStep() override;
 
     QString prettyName() const override;
     QString prettyStatus() const override;
diff --git a/src/modules/partition/core/BootLoaderModel.h b/src/modules/partition/core/BootLoaderModel.h
index 27684e326..2ef175e84 100644
--- a/src/modules/partition/core/BootLoaderModel.h
+++ b/src/modules/partition/core/BootLoaderModel.h
@@ -39,7 +39,7 @@ public:
     };
 
     BootLoaderModel( QObject* parent = 0 );
-    ~BootLoaderModel();
+    ~BootLoaderModel() override;
 
     /**
      * Init the model with the list of devices. Does *not* take ownership of the
diff --git a/src/modules/summary/SummaryViewStep.h b/src/modules/summary/SummaryViewStep.h
index b7197b71b..e1a8df89b 100644
--- a/src/modules/summary/SummaryViewStep.h
+++ b/src/modules/summary/SummaryViewStep.h
@@ -34,7 +34,7 @@ class PLUGINDLLEXPORT SummaryViewStep : public Calamares::ViewStep
 
 public:
     explicit SummaryViewStep( QObject* parent = nullptr );
-    virtual ~SummaryViewStep();
+    virtual ~SummaryViewStep() override;
 
     QString prettyName() const override;
 
diff --git a/src/modules/welcome/WelcomeViewStep.h b/src/modules/welcome/WelcomeViewStep.h
index db33a89bd..fbcbd8ded 100644
--- a/src/modules/welcome/WelcomeViewStep.h
+++ b/src/modules/welcome/WelcomeViewStep.h
@@ -37,7 +37,7 @@ class PLUGINDLLEXPORT WelcomeViewStep : public Calamares::ViewStep
 
 public:
     explicit WelcomeViewStep( QObject* parent = nullptr );
-    virtual ~WelcomeViewStep();
+    virtual ~WelcomeViewStep() override;
 
     QString prettyName() const override;