From 327c1c0e7bb7e9aac21b9b52ff7841ed0c57c36a Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Thu, 20 Feb 2020 21:40:33 +0100 Subject: [PATCH] [unpackfs] Reading from the pipe is line-oriented - Using bufsize=1 causes warnings, since we never bothered to explicitly set text mode. --- src/modules/unpackfs/main.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/unpackfs/main.py b/src/modules/unpackfs/main.py index 262bc53f8..2c523b8f7 100644 --- a/src/modules/unpackfs/main.py +++ b/src/modules/unpackfs/main.py @@ -132,7 +132,8 @@ def file_copy(source, entry, progress_cb): args.extend(["--exclude", f]) args.extend(['--progress', source, dest]) process = subprocess.Popen( - args, env=at_env, bufsize=1, stdout=subprocess.PIPE, close_fds=ON_POSIX + args, env=at_env, universal_newlines=True, bufsize=1, + stdout=subprocess.PIPE, close_fds=ON_POSIX ) # last_num_files_copied trails num_files_copied, and whenever at least 100 more # files have been copied, progress is reported and last_num_files_copied is updated.