napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[welcome] Improve logging of unsatisfied requirements

Browse Source 
- improve descriptive-strings in logging ("set?" is not very
  meaningful)
- log only the unsatisfied entries, since the preceding
  log-message suggests that that is what is happening.
This commit is contained in:
Adriaan de Groot 2021-11-01 14:24:50 +01:00
parent d972dab9b7
commit 0df288f647
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/modules/welcome/checker/CheckerContainer.cpp
View File

@ -54,9 +54,14 @@ CheckerContainer::requirementsComplete( bool ok )
for ( int i = 0; i < model.count(); ++i ) for ( int i = 0; i < model.count(); ++i )
{ {
auto index = model.index( i ); auto index = model.index( i );
cDebug() << Logger::SubEntry << i << model.data( index, Calamares::RequirementsModel::Name ).toString() const bool satisfied = model.data( index, Calamares::RequirementsModel::Satisfied ).toBool();
<< "set?" << model.data( index, Calamares::RequirementsModel::Satisfied ).toBool() << "req?" const bool mandatory = model.data( index, Calamares::RequirementsModel::Mandatory ).toBool();
<< model.data( index, Calamares::RequirementsModel::Mandatory ).toBool(); if ( !satisfied )
{
cDebug() << Logger::SubEntry << i << model.data( index, Calamares::RequirementsModel::Name ).toString()
<< "not-satisfied"
<< "mandatory?" << mandatory;
}
} }
} }