diff --git a/CHANGES-3.3 b/CHANGES-3.3 index f39c6bda8..815ef893f 100644 --- a/CHANGES-3.3 +++ b/CHANGES-3.3 @@ -8,6 +8,26 @@ changelog -- this log starts with version 3.3.0. See CHANGES-3.2 for the history of the 3.2 series (2018-05 - 2022-08). +# 3.3.0 (unreleased) + +This release contains contributions from (alphabetically by first name): + - Nobody, yet + +## Core ## + +## Modules ## + + +# 3.3.0-alpha6 (2023-11-16) + +This release contains contributions from (alphabetically by first name): + - Adriaan de Groot + - Anke Boersma + + This is a hotfix release because -alpha5 didn't compile, + and Anke repaired the partition unit-tests when building with Qt6. + + # 3.3.0-alpha5 (2023-11-13) This release contains contributions from (alphabetically by first name): diff --git a/CMakeLists.txt b/CMakeLists.txt index c3285897e..b7af98fed 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -47,7 +47,7 @@ cmake_minimum_required(VERSION 3.16 FATAL_ERROR) -set(CALAMARES_VERSION 3.3.0-alpha5) +set(CALAMARES_VERSION 3.3.0-alpha6) set(CALAMARES_RELEASE_MODE ON) # Set to ON during a release if(CMAKE_SCRIPT_MODE_FILE) diff --git a/CMakeModules/CalamaresAddModuleSubdirectory.cmake b/CMakeModules/CalamaresAddModuleSubdirectory.cmake index 61f3a1154..964dac02b 100644 --- a/CMakeModules/CalamaresAddModuleSubdirectory.cmake +++ b/CMakeModules/CalamaresAddModuleSubdirectory.cmake @@ -170,7 +170,7 @@ function( _calamares_add_module_subdirectory_impl ) if (INSTALL_CONFIG) message(" ${Green}CONFIGURATION_FILES:${ColorReset} ${MODULE_CONFIG_FILES} => [Build directory and ${MODULE_DATA_DESTINATION}]") foreach(_cf ${MODULE_CONFIG_FILES}) - install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${SUBDIRECTORY}/${_cf} DESTINATION ${MODULE_DESTINATION}) + install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${SUBDIRECTORY}/${_cf} DESTINATION ${MODULE_DATA_DESTINATION}) endforeach() else() message(" ${Green}CONFIGURATION_FILES:${ColorReset} ${MODULE_CONFIG_FILES} => [Build directory only]") diff --git a/src/libcalamares/python/Api.cpp b/src/libcalamares/python/Api.cpp index 077677911..bc5b05381 100644 --- a/src/libcalamares/python/Api.cpp +++ b/src/libcalamares/python/Api.cpp @@ -95,7 +95,7 @@ variantToPyObject( const QVariant& variant ) case QVariant::Invalid: #endif default: - return py::object(); + return py::none(); } #ifdef __clang__ #pragma clang diagnostic pop diff --git a/src/modules/dummypython/main.py b/src/modules/dummypython/main.py index 0dbbd8934..65621dd1d 100644 --- a/src/modules/dummypython/main.py +++ b/src/modules/dummypython/main.py @@ -58,6 +58,19 @@ def run(): for k in libcalamares.globalstorage.keys(): libcalamares.utils.debug(f" {k}={libcalamares.globalstorage.value(k)}") + libcalamares.utils.debug("*** GLOBAL STORAGE BOGUS KEYS ***") + # + # This is a demonstration of issue #2237, load this module + # with the dummypython/tests/1.global configuration, e.g. + # ./loadmodule -g ../src/modules/dummypython/tests/1.global dummypython + # in the build directory. + # + for k in ("nonexistent", "empty", "numeric", "boolvalue"): + if libcalamares.globalstorage.value(k) is None: + libcalamares.utils.debug(f"NONE {k}={libcalamares.globalstorage.value(k)}") + else: + libcalamares.utils.debug(f" {k}={libcalamares.globalstorage.value(k)}") + libcalamares.utils.debug("*** GLOBAL STORAGE MODIFICATION ***") libcalamares.globalstorage.insert("item2", "value2") libcalamares.globalstorage.insert("item3", 3) diff --git a/src/modules/dummypython/tests/1.global b/src/modules/dummypython/tests/1.global new file mode 100644 index 000000000..d0d194e6b --- /dev/null +++ b/src/modules/dummypython/tests/1.global @@ -0,0 +1,6 @@ +# SPDX-FileCopyrightText: no +# SPDX-License-Identifier: CC0-1.0 +--- +firmwareType: bios +bootLoader: grub +empty: diff --git a/src/modules/partition/tests/CMakeLists.txt b/src/modules/partition/tests/CMakeLists.txt index 17b79265f..1cb4ff7a1 100644 --- a/src/modules/partition/tests/CMakeLists.txt +++ b/src/modules/partition/tests/CMakeLists.txt @@ -3,12 +3,12 @@ # SPDX-FileCopyrightText: 2020 Adriaan de Groot # SPDX-License-Identifier: BSD-2-Clause # -find_package(Qt5 COMPONENTS Gui REQUIRED) +find_package(${qtname} COMPONENTS Gui REQUIRED) set(PartitionModule_SOURCE_DIR ..) include_directories( - ${Qt5Gui_INCLUDE_DIRS} + ${${qtname}Gui_INCLUDE_DIRS} ${PartitionModule_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}