napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve validation of configuration files.

Browse Source 
The validation of the configuration files (modules' .conf files,
as well as settings.conf overall) spits out warnings, but does
not do all the validation it can:
 - should print locations more clearly (e.g. if there's a tab
   in welcome.conf)
 - should also print some part of the bad text, if possible
 - if a module cannot be created, that should be treated as
   a fatal error (now the module is silently ignored). This
   is different from a module that can't be found, which
   immediately triggers a fatal failure.

Test plan:
 - introduce a tab into welcome.conf
 - introduce a bad conversion into settings.conf

With just the bad welcome.conf, it should complain clearly, and
refuse to start. With a bad conversion, it seems that there is
a problem but execution can continue, so it should be made clearer
what the problem is. If welcome.conf is buggy, and welcome is
listed to show, this should be a fatal error.
This commit is contained in:
Adriaan de Groot 2018-06-05 12:41:22 +02:00
parent 41f70975ea
commit 051b43bee6
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available